Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core][easy] disable test not suppose to work with ray client #34556

Merged
merged 1 commit into from
Apr 19, 2023
Merged

[Core][easy] disable test not suppose to work with ray client #34556

merged 1 commit into from
Apr 19, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Apr 19, 2023

this env doesn't work with ray client.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 marked this pull request as ready for review April 19, 2023 00:17
rickyyx
rickyyx approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But was it working before the str to int PR?

@scv119
Copy link
Contributor Author

scv119 commented Apr 19, 2023 •
edited
Loading

i don't think so.

@scv119 scv119 merged commit ef5bff7 into ray-project:master Apr 19, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@scv119 @elliottower
[Core][easy] disable test not suppose to work with ray client ray-pro…
3466113 
…ject#34556

this env doesn't work with ray client.

Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@scv119 @ProjectsByJackHe
[Core][easy] disable test not suppose to work with ray client ray-pro…
1e4fb41 
…ject#34556

this env doesn't work with ray client.

Signed-off-by: Jack He <[email protected]>
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
@scv119 @architkulkarni
[Core][easy] disable test not suppose to work with ray client ray-pro…
eba6747 
…ject#34556

this env doesn't work with ray client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@rickyyx rickyyx rickyyx approved these changes

Assignees

@rickyyx rickyyx

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scv119 @rickyyx @rkooo567