[Serve] Unset health replica stats when replica is under STOPPING #34761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
sihanwang41
force-pushed
the
health_replica_check
branch
from
710522a
to
216b80b
Compare
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
edoakes
approved these changes
Apr 27, 2023
Signed-off-by: sihanwang41 <[email protected]>
|
tests are unrelated |
This was referenced Apr 28, 2023
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…y-project#34761) Whenever stopping a replica, set the health stats of the replica to 0. Signed-off-by: Jack He <[email protected]>
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
…y-project#34761) Whenever stopping a replica, set the health stats of the replica to 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Whenever stopping a replica, set the health stats of the replica to 0.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.