[air/tune] use ray-provided tabulate package
#34789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2023 16:13
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
krfricke
requested review from
richardliaw,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla,
a team,
ericl,
scv119,
c21,
scottjlee,
bveeramani and
edoakes
as code owners
ericl
approved these changes
Apr 26, 2023
ericl
added
the
@author-action-required
richardliaw
approved these changes
Apr 27, 2023
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
In ray-project#26159, we added the tabulate package to the Ray repo as a thirdparty dependency. However, we still import the external tabulate package in other parts of the codebase. This PR updates these imports and gets rid of the tabulate dependency. This PR also updates the shipped tabulate version to 0.9.0. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Jack He <[email protected]>
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
In ray-project#26159, we added the tabulate package to the Ray repo as a thirdparty dependency. However, we still import the external tabulate package in other parts of the codebase. This PR updates these imports and gets rid of the tabulate dependency. This PR also updates the shipped tabulate version to 0.9.0. Signed-off-by: Kai Fricke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In #26159, we added the
tabulatepackage to the Ray repo as a thirdparty dependency.However, we still import the external tabulate package in other parts of the codebase. This PR updates these imports and gets rid of the tabulate dependency.
This PR also updates the shipped tabulate version to 0.9.0.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.