Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/docker] Fix arm64 docker image builds by downgrading miniconda #34825

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Apr 27, 2023

Why are these changes needed?

The latest release of miniconda ships with Python 3.8 as the base python. Trying to downgrade to Python 3.7 runs into unresolvable issues. Thus we pin miniconda until we stop building images for Python 3.7 (presumably once Python 3.7 is EOL, i.e. in ~2 months).

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Kai Fricke added 3 commits April 27, 2023 13:58
@krfricke
Copy link
Contributor Author

Screenshot 2023-04-27 at 4 45 40 PM

@krfricke krfricke marked this pull request as ready for review April 27, 2023 15:45
@krfricke krfricke requested a review from rkooo567 April 27, 2023 15:46
@richardliaw richardliaw merged commit 1b9a98b into ray-project:master Apr 27, 2023
@krfricke krfricke deleted the ci/fix-arm-py37-images branch April 27, 2023 17:00
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants