[Doc] Update LightningTrainer MNIST example. #34867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: woshiyyya <[email protected]>
woshiyyya
requested review from
richardliaw,
krfricke,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
matthewdeng
approved these changes
Apr 28, 2023
doc/source/train/examples/lightning/lightning_mnist_example.ipynb
Outdated
Show resolved
Hide resolved
| @@ -232,7 +225,7 @@ | |||
| " # )\n", | |||
| " config_builder.trainer(\n", | |||
| " max_epochs=10,\n", | |||
| " accelerator=\"cpu\",\n", | |||
| " accelerator=\"gpu\" if use_gpu else \"cpu\",\n", | |||
There was a problem hiding this comment.
Should the user even need to set this? Can this be inferred and set from the ScalingConfig, and if not can we just raise a warning?
Signed-off-by: woshiyyya <[email protected]>
…ning_mnist_example
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some users reported that there are some updates in lightning 2.0 and torchmetrics that our example are not compatible with. Update our example accordingly.
Changes:
Accuracy()toAccuracy(task=, num_classes=), the former one is deprecated in torchmetrics>0.9evaluation_epoch_end()toon_evaluation_epoch_end(), since the former is deprecated in ptl 2.0The two changes above are backward compatible, so it won't affect the users using lightning/torchmetrics with an older version.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.