-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[air/output] Print experiment information at experiment start #34952
[air/output] Print experiment information at experiment start #34952
Conversation
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
I feel like that this is orthogonal to Rich and trial table. WDYT? |
# Conflicts: # python/ray/tune/experimental/output.py
Yep SGTM - currently it's always being printed and I think that's how it should be. |
SGTM. Thanks! |
Signed-off-by: Kai Fricke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool cool!
also a couple of nits.
@@ -463,6 +464,31 @@ def __init__(self, verbosity: AirVerbosity): | |||
self._start_time = time.time() | |||
self._last_heartbeat_time = 0 | |||
|
|||
def experiment_started( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey we should mark all the public APIs with @DeveloperAPI or something.
so it's very clear what functions one can override to completely customize the terminal output.
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's currently experimental we don't need annotations just now (and should probably avoid them so we can continue to quickly iterate).
Before committing to the APIs, should we have a separate discussion on how and what users should be able to configure or overwrite? I don't think many people are going to write their own reporters tbh. It's more likely that they'll use configuration options to control the output, and the reporter interface is for us to implement new handlers/features if needed.
Signed-off-by: Kai Fricke <[email protected]>
…oject#34952) Includes ray-project#34788 This PR prints experiment information at the start of the experiment. Signed-off-by: Kai Fricke <[email protected]>
Why are these changes needed?
Includes #34788
This PR prints experiment information at the start of the experiment.
@scottsun94 should this also happen when rich is enabled? (Currently
disabledenabled without config table).Example:
Related issue number
Closes #34920
Closes #33154
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.