[Train] LightningTrainer enable checkpoint full dict with FSDP strategy #34967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
…sdp_checkpoint_fulldict
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
gjoliver
approved these changes
May 5, 2023
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
…gy (ray-project#34967) Signed-off-by: woshiyyya <[email protected]>
ddelange
added a commit
to ddelange/autogluon
that referenced
this pull request
Jul 3, 2023
pytorch_lightning 2.0 support added in 2.5 ray-project/ray#34967 ray_lightning deprecated ray-project/ray#36400
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In PyTorch Lightning 2.0, when using the FSDP strategy, the checkpoint does not include the model state dictionary. This PR aims to add a model unsharding logic, which gathers all model shard from workers to rank0 CPU memory.
This is a pre-request PR for FSDP LLM finetune example: #34990
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.