Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[can/test-policy] jail 4 core tests that have been failing for weeks #35045

Merged
merged 1 commit into from
May 4, 2023

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented May 4, 2023

Why are these changes needed?

Jail the following 4 tests:

  • ray-data-bulk-ingest-file-size-benchmark
  • ray-data-bulk-ingest-heterogeneity-benchmark
  • ray-data-bulk-ingest-out-of-core-benchmark
  • tune_air_oom

Should not be a surprise I think since they have been ignored during 2.4 release and prior. Context regarding release policy.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • Testing Strategy
    • Release tests

@can-anyscale can-anyscale requested review from a team May 4, 2023 16:39
@can-anyscale can-anyscale marked this pull request as ready for review May 4, 2023 16:40
Copy link

@xieus xieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Discussed with @can-anyscale. We will focus on cleaning the failed release tests to strive for greener build. As we are approaching to the end of 2.5 release cut, the jailed tests will be tagged as release blocker for 2.6 release.

@jjyao jjyao merged commit 9e636a2 into master May 4, 2023
@jjyao jjyao deleted the can-test-policy branch May 4, 2023 18:56
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
Jail the following 4 tests:

- ray-data-bulk-ingest-file-size-benchmark
- ray-data-bulk-ingest-heterogeneity-benchmark
- ray-data-bulk-ingest-out-of-core-benchmark
- tune_air_oom

Signed-off-by: Cuong Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants