Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air/mlflow] Flatten config and metrics before passing to mlflow #35074

Merged
merged 1 commit into from
May 7, 2023

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented May 5, 2023

Why are these changes needed?

Metrics and parameters are passed as-is to mlflow e.g. in the MlFlowCallback. However, mlflow can't deal with nested dicts.

Instead, we should flatten these dicts before passing them over. This leads to the desired result:

Screenshot 2023-05-05 at 11 52 42 AM

Screenshot 2023-05-05 at 11 53 15 AM

Related issue number

Closes #34857

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@GokuMohandas GokuMohandas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked like a charm, thanks @krfricke!

image

Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@krfricke krfricke merged commit 241158f into ray-project:master May 7, 2023
@krfricke krfricke deleted the air/mlflow-flatten branch May 7, 2023 13:08
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
…-project#35074)

Metrics and parameters are passed as-is to mlflow e.g. in the MlFlowCallback. However, mlflow can't deal with nested dicts.

Instead, we should flatten these dicts before passing them over. 

Signed-off-by: Kai Fricke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AIR] MLFlowCallback passes entire train_loop_config dict to parallel coordinates
3 participants