[cherry-pick][core] Sending ReportWorkerFailure after the process died. (#35320) #35420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#35320) ## Why are these changes needed? This fix is not fixing from the root ray-project#35247 And in many_nodes_actor_tests_v2, the file descriptor error still shows. This fix tries to monitor the process's liveness in some way. It also introduce a new util function which will retry the failed function until certain number. Some tests are disabled due to the race condition in detecting node failures which will be fixed later.
|
@iycheng After this PR lands in master, please create a cherry pick PR and add me as an assignee. Thanks! cc @ArturNiederfahrenhorst |
|
@iycheng actually is this PR already a cherry pick PR for t #35247? Thanks |
|
@zhe-thoughts yes, this is a cherry-pick PR. |
fishbone
changed the title
|
The master one got reverted :( I'll close this first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This fix is not fixing from the root #35247
And in many_nodes_actor_tests_v2, the file descriptor error still shows.
This fix tries to monitor the process's liveness in some way. It also introduce a new util function which will retry the failed function until certain number.
Some tests are disabled due to the race condition in detecting node failures which will be fixed later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.