Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Remove print statement + fix lint #35439

Merged
merged 2 commits into from
May 17, 2023
Merged

[serve] Remove print statement + fix lint #35439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dbdf8b
remove print
zcin May 17, 2023
9b6594d
fix lint
zcin May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion python/ray/serve/_private/http_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ def update(self):
if finished:
try:
ray.get(finished[0])
print("got object ref!")
self.set_status(HTTPProxyStatus.HEALTHY)
except Exception as e:
logger.warning(
Expand Down
6 changes: 3 additions & 3 deletions python/ray/serve/tests/test_http_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import pytest

import ray
from ray.experimental.state.api import list_actors
from ray._private.test_utils import SignalActor, wait_for_condition
from ray.serve.config import DeploymentMode, HTTPOptions
from ray.serve._private.common import HTTPProxyStatus
Expand Down Expand Up @@ -134,7 +135,6 @@ def check_proxy(status):


def test_http_proxy_shutdown():
from ray.experimental.state.api import list_actors
ray.init()

@ray.remote(num_cpus=0)
Expand Down Expand Up @@ -163,11 +163,11 @@ def check_proxy(status):
# Shutdown the http proxy state. Wait for the http proxy actor to be killed
state.shutdown()
wait_for_condition(lambda: len(list_actors(filters=[("state", "=", "ALIVE")])) == 0)

# Make sure that the state doesn't try to check on the status of the dead actor
state.update()
assert state.status == HTTPProxyStatus.HEALTHY

ray.shutdown()


Expand Down