[train] Restructure ray.train HuggingFace modules (#35270)
#35488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Organize HuggingFace integrations together. - Additional HuggingFace integrations should have a logical place to be added. - Make it simple for users to import and use integrations. - Imports should not be excessively long - Naming should be intuitive Signed-off-by: Matthew Deng <[email protected]>
matthewdeng
requested review from
richardliaw,
gjoliver,
krfricke,
xwjiang2010,
amogkam,
Yard1,
maxpumperla and
a team
as code owners
zhe-thoughts
approved these changes
May 18, 2023
There was a problem hiding this comment.
Big PR, but mostly clean renaming
Approved for picking into 2.5.0. Trusting you to fix any issues that might come up @matthewdeng ;)
Yard1
approved these changes
May 18, 2023
|
Looks like the original PR is breaking docbuild #35270 (comment) |
Signed-off-by: Matthew Deng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #35270.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.