[Train] TorchCheckpoint: Specifying pickle_protocol in torch.save()
#35615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: woshiyyya <[email protected]>
matthewdeng
reviewed
May 22, 2023
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
krfricke
reviewed
May 23, 2023
There was a problem hiding this comment.
Thanks for fixing this! Agree with @matthewdeng, let's use DEFAULT_PROTOCOL here
matthewdeng
reviewed
May 24, 2023
|
@woshiyyya Please make sure to also create the cherry pick PR yourself after this is merged! |
Signed-off-by: woshiyyya <[email protected]>
…dump_with_pickle_5
Signed-off-by: woshiyyya <[email protected]>
woshiyyya
force-pushed
the
train/torch_ckpt_dump_with_pickle_5
branch
from
6c00a3c
to
b600ded
Compare
Signed-off-by: woshiyyya <[email protected]>
matthewdeng
approved these changes
May 24, 2023
woshiyyya
changed the title
torch.save()torch.save()
…dump_with_pickle_5
|
@matthewdeng Conflicts resolved! Will ping you after CI passed. |
Signed-off-by: woshiyyya <[email protected]>
Yard1
reviewed
May 24, 2023
Signed-off-by: woshiyyya <[email protected]>
woshiyyya
force-pushed
the
train/torch_ckpt_dump_with_pickle_5
branch
from
f5870d8
to
374a4d7
Compare
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
…dump_with_pickle_5
Signed-off-by: woshiyyya <[email protected]>
Signed-off-by: woshiyyya <[email protected]>
…dump_with_pickle_5
Signed-off-by: woshiyyya <[email protected]>
woshiyyya
added
the
tests-ok
woshiyyya
added a commit
to woshiyyya/ray
that referenced
this pull request
May 25, 2023
…ray-project#35615) Signed-off-by: woshiyyya <[email protected]>
8 tasks
ArturNiederfahrenhorst
pushed a commit
that referenced
this pull request
May 26, 2023
…#35615) (#35790) Signed-off-by: woshiyyya <[email protected]>
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
…ray-project#35615) Signed-off-by: woshiyyya <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ray-project#35615) Signed-off-by: woshiyyya <[email protected]> Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
TorchCheckpoint failed to serialize large model (>4GiB) and throw serialization error. Specifying
pickle_protocol=5to resolve this issue.Details in #35611
Related issue number
Close #35611
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.