Set app_msg to empty string by default
#35646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyas Krishnaswamy <[email protected]>
Signed-off-by: Shreyas Krishnaswamy <[email protected]>
edoakes
reviewed
May 23, 2023
|
LGTM. Leave approval to @zcin. Please manually test the workflow I described in the github issue before merging. |
Co-authored-by: Edward Oakes <[email protected]> Signed-off-by: shrekris-anyscale <[email protected]>
Signed-off-by: Shreyas Krishnaswamy <[email protected]>
Good catch, I changed it.
Sure, I manually tested the |
shrekris-anyscale
changed the title
app_msg to empty string by defaultapp_msg to empty string by default
|
The test failures are unrelated:
|
|
@edoakes @architkulkarni– This change is ready to merge. |
shrekris-anyscale
added a commit
to shrekris-anyscale/ray
that referenced
this pull request
May 24, 2023
The ApplicationState currently updates its _status directly without necessarily updating the corresponding message. This causes stale messages to sometimes appear with updated statuses. This change sets the app_msg to an empty string by default, so the message is cleared or updated whenever the status is changed. Related issue number Closes ray-project#35508
8 tasks
ArturNiederfahrenhorst
pushed a commit
that referenced
this pull request
May 24, 2023
The ApplicationState currently updates its _status directly without necessarily updating the corresponding message. This causes stale messages to sometimes appear with updated statuses. This change sets the app_msg to an empty string by default, so the message is cleared or updated whenever the status is changed. Related issue number Closes #35508
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
The ApplicationState currently updates its _status directly without necessarily updating the corresponding message. This causes stale messages to sometimes appear with updated statuses. This change sets the app_msg to an empty string by default, so the message is cleared or updated whenever the status is changed. Related issue number Closes ray-project#35508
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
The ApplicationState currently updates its _status directly without necessarily updating the corresponding message. This causes stale messages to sometimes appear with updated statuses. This change sets the app_msg to an empty string by default, so the message is cleared or updated whenever the status is changed. Related issue number Closes ray-project#35508 Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
ApplicationStatecurrently updates its_statusdirectly without necessarily updating the corresponding message. This causes stale messages to sometimes appear with updated statuses. This change sets theapp_msgto an empty string by default, so the message is cleared or updated whenever the status is changed.Related issue number
Closes #35508
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.test_update_app_deploy_failedto make sure the error message is cleared.runtime_envis originally invalid.