[autoscaler] fix too many values to unpack (expected 2) bug #36231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
requested review from
wuisawesome,
DmitriGekhtman,
ericl and
a team
as code owners
scv119
added
release-blocker
rkooo567
approved these changes
Jun 8, 2023
aslonnie
reviewed
Jun 8, 2023
| self.autoscaler.all_node_types, | ||
| ) | ||
| except Exception: | ||
| logger.error("Error emitting metrics") |
There was a problem hiding this comment.
use logger.exception ? or print the stack trace?
There was a problem hiding this comment.
I don't think we want to drop the exception silently.
aslonnie
approved these changes
Jun 8, 2023
|
@scv119 , could you also get a cherrypick PR for branch |
|
The 2.5.1 branch is up, please also create a cherry pick PR for that one. |
scv119
added a commit
to scv119/ray
that referenced
this pull request
Jun 9, 2023
…ect#36231) autoscaler_summary.pending_launches is a dict thus causing the iteration fails with too many values to unpack issue.
scv119
added a commit
that referenced
this pull request
Jun 9, 2023
aslonnie
added a commit
that referenced
this pull request
Jun 15, 2023
Signed-off-by: Lonnie Liu <[email protected]>
ArturNiederfahrenhorst
pushed a commit
that referenced
this pull request
Jun 16, 2023
…36482) Signed-off-by: Lonnie Liu <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ect#36231) autoscaler_summary.pending_launches is a dict thus causing the iteration fails with too many values to unpack issue. Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoscaler_summary.pending_launches is a dict thus causing the iteration fails with
too many values to unpackissue.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.