[autoscaler] Rephrase RayletUnexpectedlyDied to RayletTerminated for more generic error message #37857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rickyyx <[email protected]>
rickyyx
requested review from
wuisawesome,
DmitriGekhtman,
ericl and
a team
as code owners
hanming-lu
approved these changes
Jul 27, 2023
scv119
approved these changes
Jul 27, 2023
scv119
reviewed
Jul 27, 2023
Signed-off-by: rickyyx <[email protected]>
rickyyx
added a commit
to rickyyx/ray
that referenced
this pull request
Jul 27, 2023
…more generic error message (ray-project#37857) --------- Signed-off-by: rickyyx <[email protected]>
8 tasks
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…more generic error message (ray-project#37857) --------- Signed-off-by: rickyyx <[email protected]> Signed-off-by: NripeshN <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…more generic error message (ray-project#37857) --------- Signed-off-by: rickyyx <[email protected]> Signed-off-by: e428265 <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…more generic error message (ray-project#37857) --------- Signed-off-by: rickyyx <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
With autoscaler v2 - we will report failure nodes could be terminated with various reasons, namely, idle termination/crash, or anything ray stopped.
The previous error message was too narrow a definition, and could be especially misleading with idle node termination.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.