Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix typos in metrics.md #37861

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[Doc] Fix typos in metrics.md #37861

merged 1 commit into from
Jul 27, 2023

Conversation

nikosavola
Copy link
Contributor

Why are these changes needed?

Small typos in docs

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@nikosavola
Fix typos in metrics.md
bb4a430 
Signed-off-by: Niko Savola <[email protected]>
architkulkarni
architkulkarni approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@architkulkarni architkulkarni self-assigned this Jul 27, 2023
@architkulkarni
Copy link
Contributor

"python-release-test" failure and "windows-wheels" test failures unrelated.

@architkulkarni architkulkarni added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jul 27, 2023
@architkulkarni architkulkarni changed the title Fix typos in metrics.md [Doc] Fix typos in metrics.md Jul 27, 2023
@architkulkarni architkulkarni merged commit 9bf15e8 into ray-project:master Jul 27, 2023
2 checks passed
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
@nikosavola @NripeshN
[Doc] Fix typos in metrics.md (ray-project#37861)
023cb5a 
Small typos in docs

Signed-off-by: Niko Savola <[email protected]>
Signed-off-by: NripeshN <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@nikosavola @arvind-chandra
[Doc] Fix typos in metrics.md (ray-project#37861)
a8ad294 
Small typos in docs

Signed-off-by: Niko Savola <[email protected]>
Signed-off-by: e428265 <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@nikosavola
[Doc] Fix typos in metrics.md (ray-project#37861)
56fc2dd 
Small typos in docs

Signed-off-by: Niko Savola <[email protected]>
Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@architkulkarni architkulkarni architkulkarni approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

Assignees

@architkulkarni architkulkarni

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikosavola @architkulkarni