-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[air] pyarrow.fs
persistence (9/n): ray.train.Checkpoint
restore: Manual restore
#38128
Merged
ericl
merged 144 commits into
ray-project:master
from
justinvyu:air/persistence/restore_new_checkpoint
Aug 10, 2023
Merged
[air] pyarrow.fs
persistence (9/n): ray.train.Checkpoint
restore: Manual restore
#38128
ericl
merged 144 commits into
ray-project:master
from
justinvyu:air/persistence/restore_new_checkpoint
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]> Update to use the new checkpoint id attribute Signed-off-by: Justin Yu <[email protected]> Add todo comment to remove legacy path Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
… -> driver Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]> Fix lint Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]> Fix lint Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…persistence/storage_context_to_worker_temp
Signed-off-by: Justin Yu <[email protected]>
…persistence/new_checkpoint Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]> Fix lint for session.py Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]> Fix lint for storage.py Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
justinvyu
removed
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Aug 9, 2023
ericl
reviewed
Aug 9, 2023
ericl
added
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Aug 9, 2023
…persistence/restore_new_checkpoint
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…persistence/restore_new_checkpoint
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
justinvyu
removed
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Aug 9, 2023
ericl
approved these changes
Aug 9, 2023
ericl
added
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Aug 9, 2023
…persistence/restore_new_checkpoint
Signed-off-by: Justin Yu <[email protected]>
justinvyu
added
tests-ok
The tagger certifies test failures are unrelated and assumes personal liability.
and removed
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
labels
Aug 9, 2023
@ericl Ok to merge |
shrekris-anyscale
pushed a commit
to shrekris-anyscale/ray
that referenced
this pull request
Aug 10, 2023
… Manual restore (ray-project#38128) Signed-off-by: Shreyas Krishnaswamy <[email protected]>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
… Manual restore (ray-project#38128) Signed-off-by: NripeshN <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
… Manual restore (ray-project#38128) Signed-off-by: e428265 <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
… Manual restore (ray-project#38128) Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds support for the new persistence path for manual trainer restoration.
API changes:
This is required to download the
pkl
files containing the info needed to manually restore an experiment, in the case that the user originally provided a custom fs.Follow-ups needed
pyarrow.fs
persistence (10/n): Unify Tune and Train sessions to support new persistence path inFunctionTrainable
#38284Tuner.restore
from a local directory that has moved #29920# TODO(justinvyu): [handle_moved_storage_path]
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.