Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile raylet cython bindings with bazel #3842

Merged
merged 7 commits into from
Jan 25, 2019
Merged

Compile raylet cython bindings with bazel #3842

merged 7 commits into from
Jan 25, 2019

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Jan 24, 2019 •
edited by robertnishihara
Loading

The plasma store can be built with:

bazel build @plasma//:plasma_server -c opt

And the raylet can be built with:

bazel build //:_raylet -c opt

Related to #2887.

@pcmoritz pcmoritz changed the title Add cython for compiling python bindings for raylet Compile raylet cython bindings with bazel Jan 24, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11119/
Test FAILed.

robertnishihara
robertnishihara reviewed Jan 24, 2019
View reviewed changes
bazel/cython_library.bzl
@@ -0,0 +1,71 @@
"""Custom rules for gRPC Python"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the role of this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is used to compile the .pyx files with cython, see

load("@//bazel:cython_library.bzl", "pyx_library")

in BUILD.bazel and

pyx_library(
    name = "_raylet",
    srcs = glob([
        "python/ray/_raylet.pyx",
        "python/ray/includes/*.pxd",
        "python/ray/includes/*.pxi"
    ]),
    deps = [":raylet_lib"]
)

robertnishihara
robertnishihara reviewed Jan 24, 2019
View reviewed changes
WORKSPACE Outdated
@@ -22,8 +22,20 @@ git_repository(
)

new_git_repository(
name = "plasma",
build_file = "@//bazel:BUILD.plasma",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original indentation was correct

robertnishihara
robertnishihara reviewed Jan 24, 2019
View reviewed changes
bazel/python_configure.bzl
@@ -0,0 +1,295 @@
# Adapted with modifications from tensorflow/third_party/py/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment pointing out the minor modifications you made to this file

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11124/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11121/
Test PASSed.

@pcmoritz pcmoritz force-pushed the baselize-cython branch 3 times, most recently from f06fab2 to b3a2524 Compare January 25, 2019 04:50
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11130/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11132/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11131/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11135/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11133/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11139/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11138/
Test PASSed.

@robertnishihara robertnishihara merged commit 20162ce into ray-project:master Jan 25, 2019
@robertnishihara robertnishihara deleted the baselize-cython branch January 25, 2019 08:57
@robertnishihara
Copy link
Collaborator

@rsepassi please take a quick look as a sanity check if you have a chance!

@rsepassi
Copy link
Contributor

looks good!

@robertnishihara
Copy link
Collaborator

Thanks @rsepassi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertnishihara robertnishihara robertnishihara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcmoritz @AmplabJenkins @robertnishihara @rsepassi