Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air] pyarrow.fs persistence: Prep removal of air.Checkpoint dependence in rllib #38590

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

justinvyu
Copy link
Contributor

@justinvyu justinvyu commented Aug 17, 2023

Why are these changes needed?

This PR prepares us to be able to delete the dependency on air.Checkpoint, by accepting the new train.Checkpoint and keeping feature parity for Algorithm.from_checkpoint.

Related issue number

#38575

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 17, 2023
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if tests are green

@justinvyu justinvyu changed the title [air] pyarrow.fs persistence: Remove air.Checkpoint dependence in rllib [air] pyarrow.fs persistence: Prep removal of air.Checkpoint dependence in rllib Aug 17, 2023
Signed-off-by: Justin Yu <[email protected]>
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR

@justinvyu justinvyu added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Aug 18, 2023
@justinvyu
Copy link
Contributor Author

Test failures are unrelated @ericl

@ericl ericl merged commit 985abd9 into ray-project:master Aug 18, 2023
2 checks passed
@justinvyu justinvyu deleted the air/persistence/rllib branch August 18, 2023 18:08
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…ndence in rllib (ray-project#38590)

This PR prepares us to be able to delete the dependency on `air.Checkpoint`, by accepting the new `train.Checkpoint` and keeping feature parity for `Algorithm.from_checkpoint`.

Signed-off-by: e428265 <[email protected]>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
…ndence in rllib (ray-project#38590)

This PR prepares us to be able to delete the dependency on `air.Checkpoint`, by accepting the new `train.Checkpoint` and keeping feature parity for `Algorithm.from_checkpoint`.

Signed-off-by: Victor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants