Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update KubeRay Ingress Docs #39635

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[docs] Update KubeRay Ingress Docs #39635

merged 1 commit into from
Sep 13, 2023

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Sep 13, 2023

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt
sync with kuberay docs
e504658 
Signed-off-by: Ian Rodney <[email protected]>
@architkulkarni architkulkarni merged commit 1da1834 into ray-project:master Sep 13, 2023
2 checks passed
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@ijrsvt
[docs] Update KubeRay Ingress Docs (ray-project#39635)
d54c522 
Incorporates changes made in [Docs] Update Security Guidance on Dashboard Ingress kuberay#1413 about ensuring that Ingresses are not publicly exposed.

Signed-off-by: Ian Rodney <[email protected]>
Signed-off-by: Victor <[email protected]>
@rickyyx rickyyx mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@architkulkarni architkulkarni architkulkarni approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@kevin85421 kevin85421 Awaiting requested review from kevin85421 kevin85421 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijrsvt @architkulkarni