Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialization test for more collection types. #3982

Merged
merged 3 commits into from
Feb 17, 2019
Merged

Add serialization test for more collection types. #3982

merged 3 commits into from
Feb 17, 2019

Conversation

robertnishihara
Copy link
Collaborator

#3846 should have been fixed by the latest update of Arrow. This adds a test for it.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11666/
Test PASSed.

guoyuhong
guoyuhong approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@guoyuhong guoyuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@guoyuhong
Copy link
Contributor

It looks like that test_passing_arguments_by_value fails.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11972/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11989/
Test FAILed.

@pcmoritz pcmoritz merged commit 5a90988 into ray-project:master Feb 17, 2019
@robertnishihara robertnishihara mentioned this pull request Feb 17, 2019
Closed
@robertnishihara robertnishihara deleted the addserializationtest branch January 7, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoyuhong guoyuhong guoyuhong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertnishihara @AmplabJenkins @guoyuhong @pcmoritz