Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc][KubeRay] Add a section for Redis cleanup #40308

Merged
merged 3 commits into from
Oct 17, 2023
Merged

[Doc][KubeRay] Add a section for Redis cleanup #40308

merged 3 commits into from
Oct 17, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Oct 13, 2023 •
edited
Loading

Why are these changes needed?

Add a section to explain ray-project/kuberay#1412.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kevin85421
update
5057eda 
Signed-off-by: Kai-Hsun Chen <[email protected]>
@kevin85421 kevin85421 marked this pull request as ready for review October 13, 2023 01:13
hongchaodeng
hongchaodeng approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nit!

doc/source/cluster/kubernetes/user-guides/kuberay-gcs-ft.md Outdated Show resolved Hide resolved
doc/source/cluster/kubernetes/user-guides/kuberay-gcs-ft.md Outdated Show resolved Hide resolved
@architkulkarni architkulkarni self-assigned this Oct 17, 2023
@architkulkarni architkulkarni merged commit f787843 into ray-project:master Oct 17, 2023
14 of 15 checks passed
@kevin85421 kevin85421 mentioned this pull request Oct 19, 2023
Closed
2 tasks
@rickyyx rickyyx mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@architkulkarni architkulkarni architkulkarni approved these changes

@hongchaodeng hongchaodeng hongchaodeng approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

Assignees

@gvspraveen gvspraveen

@hongchaodeng hongchaodeng

@architkulkarni architkulkarni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevin85421 @hongchaodeng @architkulkarni @gvspraveen