Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash for Java task's task.argument() in state. #4063

Merged
merged 7 commits into from
Feb 19, 2019
Merged

Fix crash for Java task's task.argument() in state. #4063

merged 7 commits into from
Feb 19, 2019

Conversation

jovany-wang
Copy link
Contributor

@jovany-wang jovany-wang commented Feb 15, 2019 •
edited
Loading

What do these changes do?

Since pickle.loads() couldn't load the data to a Java object, skiping it for Java object does make sense.

Related issue number

This fixes #3780

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11993/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11995/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11994/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11999/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11998/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12023/
Test FAILed.

@jovany-wang
Copy link
Contributor Author

@raulchen @robertnishihara cc

raulchen
raulchen reviewed Feb 17, 2019
View reviewed changes
python/ray/experimental/state.py Outdated
# to Java object in `task.arguments()`.
"Args": (task.arguments()
if task.language() == ray.gcs_utils.Language.PYTHON else
"<java-argument>"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"<java-argument>" -> ["<java-argument>"]
this should be a list

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12047/
Test FAILed.

@jovany-wang
Copy link
Contributor Author

The CI complained about a linting error which is not related to my changes...

@robertnishihara
Copy link
Collaborator

I think the linting change should be fixed in the master. Maybe rebase?

@jovany-wang
Copy link
Contributor Author

I have rebased current master. :)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12061/
Test FAILed.

raulchen
raulchen reviewed Feb 18, 2019
View reviewed changes
python/ray/experimental/state.py Outdated
# to Java object in `task.arguments()`.
"Args": (task.arguments()
if task.language() == ray.gcs_utils.Language.PYTHON else
["<java-argument>"]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix this issue inside the arguments method, otherwise if someone else calls arguments, it will also crash.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12074/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12086/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12090/
Test FAILed.

@raulchen raulchen merged commit 7574757 into ray-project:master Feb 19, 2019
@jovany-wang jovany-wang deleted the fix-java-py-convert branch February 20, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to execute state.task_table() when running a Java App
4 participants
@jovany-wang @AmplabJenkins @robertnishihara @raulchen