-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] mig auto detection #41103
Open
jonathan-anyscale
wants to merge
13
commits into
ray-project:master
Choose a base branch
from
jonathan-anyscale:mig_detection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Core] mig auto detection #41103
jonathan-anyscale
wants to merge
13
commits into
ray-project:master
from
jonathan-anyscale:mig_detection
+127
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
@wookayin @XuehaiPan any reviews are appreciated!! |
XuehaiPan
reviewed
Nov 14, 2023
XuehaiPan
reviewed
Nov 14, 2023
XuehaiPan
reviewed
Nov 14, 2023
Co-authored-by: Xuehai Pan <[email protected]> Signed-off-by: jonathan-anyscale <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
jjyao
reviewed
Nov 14, 2023
Signed-off-by: Jonathan Nitisastro <[email protected]>
jonathan-anyscale
force-pushed
the
mig_detection
branch
from
November 15, 2023 06:55
13ce2c0
to
9448f53
Compare
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
jonathan-anyscale
force-pushed
the
mig_detection
branch
from
November 16, 2023 22:22
adc9b99
to
a674b38
Compare
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
jjyao
reviewed
Dec 20, 2023
Signed-off-by: Jonathan Nitisastro <[email protected]>
Hi @jonathan-anyscale any progress on merging this commit? |
Hi @jjyao, can this PR be merged? Happy to give a hand to fix broken tests if it can help. |
Also interested in this being merged - any ideas when it'll make into a release? |
anyscalesam
added
triage
Needs triage (eg: priority, bug/not-bug, and owning component)
core
Issues that should be addressed in Ray Core
labels
May 29, 2024
jjyao
removed
the
triage
Needs triage (eg: priority, bug/not-bug, and owning component)
label
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add MIG device to auto detection. User can enable this feature by setting
RAY_ENABLE_MIG_DETECTION
env variable during ray start:RAY_ENABLE_MIG_DETECTION=true ray start --head
Related issue number
#12413
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.