Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] mig auto detection #41103

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

jonathan-anyscale
Copy link
Contributor

@jonathan-anyscale jonathan-anyscale commented Nov 13, 2023

Why are these changes needed?

Add MIG device to auto detection. User can enable this feature by setting RAY_ENABLE_MIG_DETECTION env variable during ray start:
RAY_ENABLE_MIG_DETECTION=true ray start --head

Related issue number

#12413

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
@jonathan-anyscale
Copy link
Contributor Author

@wookayin @XuehaiPan any reviews are appreciated!!

jonathan-anyscale and others added 2 commits November 13, 2023 20:58
Co-authored-by: Xuehai Pan <[email protected]>
Signed-off-by: jonathan-anyscale <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
@jjyao jjyao requested a review from XuehaiPan November 14, 2023 19:26
python/ray/scripts/scripts.py Outdated Show resolved Hide resolved
python/ray/_private/accelerators/nvidia_gpu.py Outdated Show resolved Hide resolved
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
jonathan-anyscale and others added 4 commits November 26, 2023 16:29
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
@mbadala
Copy link

mbadala commented Feb 16, 2024

Hi @jonathan-anyscale any progress on merging this commit?

@dulacp
Copy link

dulacp commented Mar 12, 2024

Hi @jjyao, can this PR be merged? Happy to give a hand to fix broken tests if it can help.

@agon-shabi
Copy link

Also interested in this being merged - any ideas when it'll make into a release?

@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core labels May 29, 2024
@jjyao jjyao removed the triage Needs triage (eg: priority, bug/not-bug, and owning component) label Sep 16, 2024
@jjyao jjyao added the P1 Issue that should be fixed within a few weeks label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants