Cross-language invocation Part 1: Java calling Python functions and actors #4166

raulchen · 2019-02-26T14:00:53Z

What do these changes do?

Implements Java calling Python functions and actors.

Usage:

Call a Python function:

RayObject res = Ray.callPy("module_name", "function_name", arg1, arg2, ...);

Call a Python actor:

RayPyActor actor = Ray.createPyActor("module_name", "ClassName", arg1, arg2, ...);
RayObject res = Ray.callPy(actor, "function_name", arg1, arg2);

Note, currently arguments can only be raw binaries. And when putting a binary in object store, we use special metadata to indicate that the object is raw binary and doesn't need serialization/deserialization.

Not implemented in this PR:

Python calling Java.
Passing actor handle as parameter.

Related issue number

#2576

AmplabJenkins · 2019-02-26T23:07:48Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12321/
Test FAILed.

pcmoritz · 2019-02-27T22:33:55Z

If we got the eternal bug https://issues.apache.org/jira/browse/ARROW-1692 resolved, we could pass data natively between Java arrow and python arrow :D

ericl · 2019-03-06T07:46:29Z

java/api/src/main/java/org/ray/api/RayCall.java

+  public static RayPyActor createPyActor(String moduleName, String className, Object obj0, Object obj1, Object obj2, Object obj3, Object obj4, Object obj5, ActorCreationOptions options) {
+    Object[] args = new Object[]{obj0, obj1, obj2, obj3, obj4, obj5};
+    return Ray.internal().createPyActor(moduleName, className, args, options);
+  }


Since these args are all untyped, why not use Java varargs? The only caveat is that you'll have to move the creation options a bit earlier.

yeah, varargs would look nicer. But I wanted to make the order aligned with the regular createActor.

ericl · 2019-03-06T07:51:05Z

java/runtime/src/main/java/org/ray/runtime/RayPyActorImpl.java

+    return className;
+  }
+
+  public RayPyActorImpl fork(boolean random) {


What's the random arg for?

Oops, that's an internal hack. I'll remove it.

ericl · 2019-03-06T07:55:37Z

java/runtime/src/main/java/org/ray/runtime/raylet/RayletClientImpl.java

+    int language;
+    int functionDescriptorOffset;
+
+    if (task.functionDescriptor != null) {


I found the nullability of functionDescriptor / pyFuncDescriptor confusing. Consider having one type for both, and methods task.functionDescriptor.getLanguage() instead.

sounds good.

ericl · 2019-03-06T07:57:40Z

java/runtime/src/main/java/org/ray/runtime/task/TaskSpec.java

  public final FunctionDescriptor functionDescriptor;

+  // Descriptor of the target Python function. This field is only valid for Python tasks.
+  public final PyFunctionDescriptor pyFunctionDescriptor;


Consider merging these two fields to avoid nulls.

ericl · 2019-03-06T08:02:10Z

java/runtime/src/main/java/org/ray/runtime/AbstractRayRuntime.java

+      actorImpl.setTaskCursor(spec.returnIds[1]);
+      actorImpl.clearNewActorHandles();
+    }
+    rayletClient.submitTask(spec);


ericl · 2019-03-06T08:02:38Z

java/runtime/src/main/java/org/ray/runtime/AbstractRayRuntime.java

+    return actor;
+  }
+
+


Too many newlines?

ericl · 2019-03-06T08:03:45Z

java/pom.xml

+        <groupId>com.google.code.gson</groupId>
+        <artifactId>gson</artifactId>
+        <version>2.8.5</version>
+      </dependency>


What's gson for?

It's actually needed for the next PR (serializing handle with json and pass it to Python), forgot to remove it.

ericl

Left a few comments.

AmplabJenkins · 2019-03-11T07:09:49Z

Can one of the admins verify this patch?

AmplabJenkins · 2019-03-11T21:48:42Z

Can one of the admins verify this patch?

ericl · 2019-03-16T00:45:00Z

@raulchen any follow-up here? Looks like there are some merge conflicts now.

raulchen · 2019-03-19T11:35:24Z

@ericl I rebased the PR and addressed your comments.

AmplabJenkins · 2019-03-19T12:43:24Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13036/
Test PASSed.

AmplabJenkins · 2019-03-19T20:36:10Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13046/
Test PASSed.

AmplabJenkins · 2019-03-20T07:21:32Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13070/
Test PASSed.

AmplabJenkins · 2019-03-20T12:17:18Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13089/
Test PASSed.

raulchen · 2019-03-20T14:54:28Z

CI failure is related, but I cannot reproduce it on my machine. Will check tomorrow.

ericl · 2019-03-20T19:13:38Z

java/runtime/src/main/java/org/ray/runtime/functionmanager/PyFunctionDescriptor.java

+/**
+ * Represents metadata of a Python function.
+ */
+public class PyFunctionDescriptor {


For the sake of a little more type safety, how about having both this and FunctionDescriptor extend the same interface or base class?

Thanks, will change.

ericl

Looks good -- just one comment on having a common base class for a bit more type safety.

It would also be nice to add an example of Python->Java calls, if there is a use case for that.

AmplabJenkins · 2019-03-20T19:39:51Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13100/
Test FAILed.

This reverts commit 1dcec80.

raulchen · 2019-03-21T03:28:10Z

@ericl Python calling Java will be implemented in next PR. Although it's already doable with low-level api, I'd like to create a higher-level API for convenience in next PR. I haven't thought thoroughly about the API, it may be something like the following. Suggestions are welcome!

java_func = ray.experimental.java_task("package.name", "ClassName", "staticMethodName", "typeDescriptor")
java_func.remote(args)

java_actor = ray.experimental.create_java_actor("package.name", "ClassName")
java_actor.method("methodName", "typeDescriptor").remote(args)

ericl · 2019-03-21T03:41:30Z

Sounds good. I think the experimental syntax looks fine for an initial release; you could also try to wrap the actors to provide a bit more of a pythonic API.

AmplabJenkins · 2019-03-21T05:23:01Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13126/
Test FAILed.

AmplabJenkins · 2019-03-21T05:31:03Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13123/
Test FAILed.

AmplabJenkins · 2019-03-21T06:04:22Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13127/
Test PASSed.

raulchen changed the title ~~[wip] Cross-language invocation: part 1~~ Cross-language invocation: part 1 Feb 26, 2019

raulchen requested review from guoyuhong and robertnishihara March 1, 2019 07:41

robertnishihara assigned ericl Mar 6, 2019

ericl reviewed Mar 6, 2019

View reviewed changes

ericl requested changes Mar 6, 2019

View reviewed changes

raulchen added 2 commits March 19, 2019 17:34

Cross-language invocation

896b944

remove unneeded code

de1960e

raulchen force-pushed the xlang branch from cbede3f to de1960e Compare March 19, 2019 09:55

raulchen added 2 commits March 19, 2019 18:43

fix

d0a3ebc

fix

d94ee84

raulchen force-pushed the xlang branch from 16d5d09 to d94ee84 Compare March 19, 2019 11:35

format

af7cca5

fix

a626edb

raulchen changed the title ~~Cross-language invocation: part 1~~ Cross-language invocation Part 1: Java calling Python functions and actors Mar 20, 2019

don't trim stack trace

f22685f

debug

1dcec80

ericl reviewed Mar 20, 2019

View reviewed changes

ericl approved these changes Mar 20, 2019

View reviewed changes

raulchen added 4 commits March 21, 2019 10:18

Revert "debug"

c4f0b35

This reverts commit 1dcec80.

fix

b13ff1f

type safe descriptor

8b7d1e6

refine comment

5d2ab7d

raulchen merged commit d03999d into ray-project:master Mar 21, 2019

raulchen deleted the xlang branch March 21, 2019 05:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cross-language invocation Part 1: Java calling Python functions and actors #4166

Cross-language invocation Part 1: Java calling Python functions and actors #4166

raulchen commented Feb 26, 2019 •

edited

Loading

AmplabJenkins commented Feb 26, 2019

pcmoritz commented Feb 27, 2019 •

edited

Loading

ericl Mar 6, 2019

raulchen Mar 6, 2019

ericl Mar 6, 2019

raulchen Mar 6, 2019

ericl Mar 6, 2019

raulchen Mar 6, 2019

ericl Mar 6, 2019

ericl Mar 6, 2019

ericl Mar 6, 2019

ericl Mar 6, 2019

raulchen Mar 6, 2019

ericl left a comment

AmplabJenkins commented Mar 11, 2019

AmplabJenkins commented Mar 11, 2019

ericl commented Mar 16, 2019 •

edited

Loading

raulchen commented Mar 19, 2019

AmplabJenkins commented Mar 19, 2019

AmplabJenkins commented Mar 19, 2019

AmplabJenkins commented Mar 20, 2019

AmplabJenkins commented Mar 20, 2019

raulchen commented Mar 20, 2019

ericl Mar 20, 2019

raulchen Mar 21, 2019

ericl left a comment

AmplabJenkins commented Mar 20, 2019

raulchen commented Mar 21, 2019 •

edited

Loading

ericl commented Mar 21, 2019

AmplabJenkins commented Mar 21, 2019

AmplabJenkins commented Mar 21, 2019

AmplabJenkins commented Mar 21, 2019

Cross-language invocation Part 1: Java calling Python functions and actors #4166

Cross-language invocation Part 1: Java calling Python functions and actors #4166

Conversation

raulchen commented Feb 26, 2019 • edited Loading

What do these changes do?

Related issue number

AmplabJenkins commented Feb 26, 2019

pcmoritz commented Feb 27, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericl left a comment

Choose a reason for hiding this comment

AmplabJenkins commented Mar 11, 2019

AmplabJenkins commented Mar 11, 2019

ericl commented Mar 16, 2019 • edited Loading

raulchen commented Mar 19, 2019

AmplabJenkins commented Mar 19, 2019

AmplabJenkins commented Mar 19, 2019

AmplabJenkins commented Mar 20, 2019

AmplabJenkins commented Mar 20, 2019

raulchen commented Mar 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericl left a comment

Choose a reason for hiding this comment

AmplabJenkins commented Mar 20, 2019

raulchen commented Mar 21, 2019 • edited Loading

ericl commented Mar 21, 2019

AmplabJenkins commented Mar 21, 2019

AmplabJenkins commented Mar 21, 2019

AmplabJenkins commented Mar 21, 2019

raulchen commented Feb 26, 2019 •

edited

Loading

pcmoritz commented Feb 27, 2019 •

edited

Loading

ericl commented Mar 16, 2019 •

edited

Loading

raulchen commented Mar 21, 2019 •

edited

Loading