Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ray stop command also kill Java workers #4179

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Make ray stop command also kill Java workers #4179

merged 2 commits into from
Mar 1, 2019

Conversation

raulchen
Copy link
Contributor

What do these changes do?

Make ray stop command also kill Java workers. Also clean up code and ignore ImportError of notebook module.

Related issue number

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12347/
Test FAILed.

guoyuhong
guoyuhong approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@guoyuhong guoyuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is much cleaner.

@raulchen raulchen merged commit 14ff402 into ray-project:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoyuhong guoyuhong guoyuhong approved these changes

@robertnishihara robertnishihara robertnishihara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raulchen @AmplabJenkins @robertnishihara @guoyuhong