Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest arrow wheels #4182

Merged
merged 15 commits into from
Feb 28, 2019
Merged

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Feb 27, 2019

The arrow wheels are built from https://github.com/ray-project/arrow-build

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12358/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12356/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12359/
Test FAILed.

@@ -24,19 +24,17 @@ if [[ "$PYTHON" == "2.7" ]] && [[ "$platform" == "linux" ]]; then
wget https://repo.continuum.io/miniconda/Miniconda2-4.5.4-Linux-x86_64.sh -O miniconda.sh -nv
bash miniconda.sh -b -p $HOME/miniconda
export PATH="$HOME/miniconda/bin:$PATH"
pip install -q cython==0.29.0 gym==0.10.11 opencv-python-headless pyyaml pandas==0.23.4 requests \
pip install -q scipy tensorflow cython==0.29.0 cmake gym==0.10.11 opencv-python-headless pyyaml pandas==0.23.4 requests \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need cmake here (and below), right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12377/
Test FAILed.

Copy link
Contributor

@guoyuhong guoyuhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcmoritz Could you squash all the commits in your branch https://github.com/pcmoritz/arrow/commits/ubuntu-wheels into one commit? That will be easier for us to merge into our internal repo.

@pcmoritz
Copy link
Contributor Author

@guoyuhong This will be squashed as part of apache/arrow#3766 when it is merged upstream into arrow. My branch is only temporary.

@guoyuhong
Copy link
Contributor

@pcmoritz Thanks for the information. That's great!

--target=$ROOT_DIR/python/ray/pyarrow_files pyarrow==0.12.0-RAY \
--find-links https://s3-us-west-2.amazonaws.com/arrow-wheels/bf0f3a15e0d6583cfaedbca508627b06746fa41a/index.html
--target=$ROOT_DIR/python/ray/pyarrow_files pyarrow==0.12.0.RAY \
--find-links https://s3-us-west-2.amazonaws.com/arrow-wheels/9357dc130789ee42f8181d8724bee1d5d1509060/index.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 9357dc130789ee42f8181d8724bee1d5d1509060 an actual Arrow commit? I don't have a way of knowing what branch or where this comes from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a commit of https://github.com/ray-project/arrow-build (right now it's the current master), which contains the arrow commit; this is described in the comment above

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, in the future, I think it'd be preferable to make the S3 folder have the same name as the arrow commit instead of the arrow-build commit.

@robertnishihara robertnishihara merged commit 4dc683d into ray-project:master Feb 28, 2019
@robertnishihara robertnishihara deleted the test-ubuntu-wheels branch February 28, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants