[rllib] Reserve CPUs for replay actors in apex #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
richardliaw
approved these changes
Mar 3, 2019
|
jenkins retest this please |
|
Test FAILed. |
ericl
added a commit
to ericl/ray
that referenced
this pull request
Mar 19, 2019
)" This reverts commit 2781d74.
ericl
added a commit
that referenced
this pull request
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Previously we removed these as an optimization, but since running a method on a 0-cpu actor actually waits for a CPU slot, it is a bit safer to reserve them ahead of time. This avoids any silent perf degradation if the CPUs are heavily contended.