Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Add custom field for serializations #4237

Merged
merged 6 commits into from
Mar 8, 2019
Merged

[tune] Add custom field for serializations #4237

merged 6 commits into from
Mar 8, 2019

Conversation

richardliaw
Copy link
Contributor

@richardliaw richardliaw commented Mar 3, 2019 •
edited
Loading

Fixes GeneticSearcher output.

Fixes #4233.

@richardliaw
Copy link
Contributor Author

@old-bear

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12509/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12510/
Test FAILed.

ericl
ericl previously requested changes Mar 6, 2019
View reviewed changes
python/ray/tune/automl/search_policy.py Outdated
@@ -98,6 +98,10 @@ def next_trials(self):
trial.best_result = None
trial.param_config = param_config
trial.extra_arg = extra_arg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider instead making these fields native to trial.

@richardliaw richardliaw requested a review from ericl March 7, 2019 04:21
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12646/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12648/
Test FAILed.

@richardliaw richardliaw merged commit c3a3360 into ray-project:master Mar 8, 2019
@richardliaw richardliaw deleted the tune_update_tests branch March 8, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardliaw @AmplabJenkins @ericl