[data] Warn on excessive driver memory usage during shuffle ops #42574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephanie Wang <[email protected]>
Signed-off-by: Stephanie Wang <[email protected]>
stephanie-wang
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen and
Zandew
as code owners
c21
reviewed
Jan 23, 2024
There was a problem hiding this comment.
Thanks @stephanie-wang. Change on data directory looks good to me, except one comment.
| # If driver memory exceeds this threshold, warn the user. For now, this | ||
| # only applies to shuffle ops because most other ops are unlikely to use as | ||
| # much driver memory. | ||
| warn_on_driver_memory_usage_bytes: Optional[int] = None |
There was a problem hiding this comment.
Can we pass this argument through DataContext to ExchangeTaskScheduler.execute(warn_on_driver_memory_usage_bytes=...) directly?
TaskContext ideally should only contain the unique information per each task. Feeling it does not need to go through TaskContext in this case.
There was a problem hiding this comment.
Thanks, moved to ExchangeTaskScheduler.
Signed-off-by: Stephanie Wang <[email protected]>
Signed-off-by: Stephanie Wang <[email protected]>
stephanie-wang
added
the
tests-ok
c21
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Warns the user if too much driver memory is used for:
Related issue number
Closes #40861.