[Data] Add retry for _sample_fragment during ParquetDatasource._estimate_files_encoding_ratio()
#42759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]>
raulchen
approved these changes
Jan 27, 2024
Signed-off-by: Scott Lee <[email protected]>
scottjlee
requested review from
ericl,
scv119,
c21,
amogkam,
bveeramani,
stephanie-wang and
Zandew
as code owners
c21
reviewed
Jan 27, 2024
| sample_fragment.options( | ||
| scheduling_strategy=scheduling, | ||
| # Retry in case of transient errors during sampling. | ||
| retry_exceptions=[OSError], |
There was a problem hiding this comment.
Let's extract this as a variable similar to RETRY_EXCEPTIONS_FOR_META_FETCH_TASK, so we can tune later.
There was a problem hiding this comment.
discussed with @scottjlee , we'll make this configurable in DataContext. Since other retry errors are not configurable either. we'll use a follow-up PR to update all.
There was a problem hiding this comment.
I feel it's okay to not put into DataContext. I don't think they are user-facing, and mostly it only should be tuned by ourselves, when debugging user job. Let's only add config to DataContext if they are expected to be set by users.
There was a problem hiding this comment.
But agreed to merge this PR ASAP to unblock users.
scottjlee
added a commit
to scottjlee/ray
that referenced
this pull request
Jan 27, 2024
…timate_files_encoding_ratio()` (ray-project#42759)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Sometimes, there can be transient errors during the fragment sampling phase of
read_parquet(), when Ray Data estimates the file encoding ratio prior to execution. We include this fragment sampling phase into a retry loop so that we automatically retry upon failure.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.