Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[train] remove DEFAULT_NCCL_SOCKET_IFNAME #42808

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Jan 29, 2024

Why are these changes needed?

This was originally added in #28633, #31824 in an attempt to set sensible default configurations. After further investigating, it appears that users actually expect (and prefer) the default unset values.

This PR also removes additional configs set in release tests, as the test environments have already been configured properly.

Related issue number

Closes #42652
Closes #32519

Checks

Release Tests (See AWS tests): https://buildkite.com/ray-project/release/builds/7192

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
@matthewdeng matthewdeng marked this pull request as ready for review January 31, 2024 18:29
release/xgboost_tests/app_config_gpu.yaml Show resolved Hide resolved
python/ray/train/torch/config.py Show resolved Hide resolved
Signed-off-by: Matthew Deng <[email protected]>
@woshiyyya
Copy link
Member

Looks good! Thanks for the cleanup. Let's merge it.

@matthewdeng matthewdeng merged commit 6eb1814 into ray-project:master Feb 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Train] Ray Train sets wrong interface on NCCL [Train] Clean up NCCL_SOCKET_IFNAME test configurations
3 participants