[RLlib] Prioritized version of an episode-based replay buffer. #42832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
…change 'self_indices' from 'list' to ' dict' to lookup indices at indices of 'SegmentTree's. Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
…Buffer' and added 'update_priorities()', 'set_state()' and 'get_state()'. Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
8 tasks
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
sven1977
changed the title
…used. It needs a multi-agent version of the episode replay buffer, however. Signed-off-by: Simon Zehnder <[email protected]>
sven1977
reviewed
Jan 31, 2024
| @@ -21,6 +23,38 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def update_priorities_in_episode_replay_buffer( | |||
| replay_buffer: EpisodeReplayBuffer, | |||
There was a problem hiding this comment.
nit: PrioritizedEpisodeReplayBuffer ?
There was a problem hiding this comment.
Basically yes, but if it is not a prioritized buffer the function just skips and returns. Like this we can use normal buffers or prioritized ones. The other possibility is to test for the kind of buffer in the algorithms.
sven1977
reviewed
Jan 31, 2024
Signed-off-by: Simon Zehnder <[email protected]>
sven1977
reviewed
Jan 31, 2024
sven1977
reviewed
Jan 31, 2024
rllib/utils/replay_buffers/prioritized_episode_replay_buffer.py
Outdated
Show resolved
Hide resolved
sven1977
reviewed
Jan 31, 2024
rllib/utils/replay_buffers/prioritized_episode_replay_buffer.py
Outdated
Show resolved
Hide resolved
sven1977
reviewed
Jan 31, 2024
rllib/utils/replay_buffers/prioritized_episode_replay_buffer.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Zehnder <[email protected]>
Co-authored-by: Sven Mika <[email protected]> Signed-off-by: simonsays1980 <[email protected]>
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla and
kouroshHakha
as code owners
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Signed-off-by: Simon Zehnder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Changing to the new
EnvRunner APIfor sampling and therein to focus on episodes instead of batches, we need to have replay buffers that can handle episodes. TheEpisodeReplayBufferwas a simple replay buffer to deal with sequences, but offers no prioritized replay. This PR wants to change that by adding a prioritized replay buffer based on storing episodes and replay the transitions within in a prioritized way.Related issue number
#42369
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.