[2.9.2][Data] Skip recording memory spilled stats when get_memory_info_reply is failed #42834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is failed (ray-project#42824) User found the issue the call of `get_memory_info_reply` throws GRPC error if memory load on cluster is heavy. Signed-off-by: Cheng Su <[email protected]>
c21
requested review from
ericl,
scv119,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
Zandew
as code owners
c21
changed the title
zhe-thoughts
approved these changes
Jan 30, 2024
bveeramani
approved these changes
Jan 30, 2024
c21
added
the
tests-ok
|
PR is good to merge. |
architkulkarni
merged commit 0784b9d
into
ray-project:releases/2.9.2
14 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User found the issue the call of
get_memory_info_replythrows GRPC error if memory load on cluster is heavy.Why are these changes needed?
Cherry pick of #42824 to 2.9.2 release branch.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.