-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Use application-level retries for Parquet metadata tasks #42922
Conversation
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bveeramani! Having some comments.
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the test for the user workload.
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error message LGTM
Why are these changes needed?
#42044 updated the
ParquetDatasource
logic so that Ray retries metadata fetching tasks that raiseOSError
s.ray/python/ray/data/datasource/parquet_datasource.py
Lines 295 to 298 in ba3cfa0
The problem is that we retry tasks indefinitely, so if a metadata fetching tasks raises a non-transient
OSError
, your program freezes without warning.ray/python/ray/data/_internal/remote_fn.py
Line 26 in ba3cfa0
To fix this issue, this PR replaces the Ray Core-level retry with finite application-level retries. It also updates the retry logic to apply jitter to backoffs that exceed the limit.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.