-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[train] support memory per worker #42999
[train] support memory per worker #42999
Conversation
Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! See the comment about also needing to update ScalingConfig.as_placement_group_factory
, and also a request for the unit test.
Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
Signed-off-by: Matthew Deng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to Go!
Also Thanks for cleaning up the redundant input arguments.
Why are these changes needed?
This enables scheduling Ray Train Workers by specifying
"memory"
inScalingConfig.resources_per_worker
. This additional logic is necessary because Ray Actors require the specialmemory
kwarg rather than a"memory"
entry in theresources
dictionary.As part of this change, I am also changing the interface of
BackendExecutor
andWorkerGroup
to simply take a dictionary for allresources
. This matches the interface ofScalingConfig
andPlacementGroup
, and centralizes all logic to convert to Ray Actor/Task kwargs inWorkerGroup
.Example:
Before:
After:
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.