[tune] Fix worker recovery by setting force=False when calling logger sync_now
#4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartikainen
changed the title
force=False when calling logger sync_now
richardliaw
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
After Eric's #4218 goes in, we should also add warn_if_slow to most of these things.
|
Test FAILed. |
hartikainen
force-pushed
the
fix/tune-logger-flush-force
branch
from
6ecba9b
to
8448c36
Compare
|
Test FAILed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes a tune autoscaling problem where worker recovery causes things to stall.