-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time streaming exec scheduling #43112
Conversation
Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: Matthew Owen <[email protected]>
Conducted some manual testing with the following snippet (and adding a line to log the time from within def sleep(x):
time.sleep(0.5)
return x
num_rows = sys.argv[1] if len(sys.argv) > 1 else 10
ds = ray.data.range(num_rows).map(sleep)
for _ in ds.iter_batches(batch_size=1):
continue For |
Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: Matthew Owen <[email protected]>
Signed-off-by: Matthew Owen <[email protected]>
Seem to broke linux://python/ray/data:test_streaming_integration |
I'm trying to revert to unblock test failures |
This reverts commit 9641c72.
)" (ray-project#43283)" This reverts commit 2b92f57. Signed-off-by: Matthew Owen <[email protected]>
…)" (#43433) This adds an extra `None` check to fix test failures if `self._initial_stats` is not set. This reverts #43283 and restores the changes made in #43112 . Signed-off-by: Matthew Owen <[email protected]>
Why are these changes needed?
Currently we are not timing how much time is spent during scheduling in the streaming executor. This times the total
process_time
for the scheduling steps / calls to_scheduling_loop_step
. This stat is included in DatasetStats and a later PR will include this and other StreamingExecutor stats into the DatasetStatsSummary.Related issue number
Closes #42797
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.