[train+data] Remove preprocessor argument from trainers
#43146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
justinvyu
commented
Feb 13, 2024
Comment on lines
+674
to
680
| # Evaluate datasets if they are wrapped in a factory. | ||
| trainer.datasets = { | ||
| k: d() if callable(d) else d for k, d in self.datasets.items() | ||
| } | ||
|
|
||
| trainer.setup() | ||
| trainer.preprocess_datasets() | ||
| trainer.training_loop() |
There was a problem hiding this comment.
preprocess_datasets used to do this "evaluation" of the dataset factory function, plus any dataset preprocessing from Trainer.preprocessor. This interface is not needed so I removed it, and brought the evaluation logic out.
matthewdeng
approved these changes
Feb 13, 2024
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…ve_preprocessor Signed-off-by: Justin Yu <[email protected]>
raulchen
approved these changes
Feb 14, 2024
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR removes the hard-deprecated
preprocessorargument fully. This is a follow-up to #38640.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.