Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TCP_NODELAY on all TCP connections #4318

Merged
merged 2 commits into from
Mar 9, 2019
Merged

Set TCP_NODELAY on all TCP connections #4318

merged 2 commits into from
Mar 9, 2019

Conversation

stephanie-wang
Copy link
Contributor

What do these changes do?

I found that Nagle's algorithm sometimes leads to delays of 10s of ms before a message is delivered. This disables the algorithm with TCP_NODELAY.

pcmoritz
pcmoritz approved these changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12715/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12716/
Test FAILed.

@pcmoritz pcmoritz merged commit edc7947 into ray-project:master Mar 9, 2019
@robertnishihara robertnishihara deleted the tcp-no-delay branch March 10, 2019 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanie-wang @AmplabJenkins @pcmoritz