-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tune] add-note command for Tune CLI #4321
Conversation
Questions:
|
Test FAILed. |
Test FAILed. |
Well, the default should just be
Full name should be good.
Yeah, that should be fine.
What do you have in mind for this? |
This is nice! I think it would also be great to be able to add notes when launching an experiment. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine for now; I'll try this out tomorrow.
I think later on this should maybe somehow use a starter template?
Hm, via |
Test FAILed. |
Co-Authored-By: andrewztan <[email protected]>
Test PASSed. |
@richardliaw Yeah, something like |
Test PASSed. |
@hartikainen I'll merge this for now (just as a preliminary first cut to get something in), but in a later PR we'll expose the contents of this note file through |
@andrewztan nice work! |
What do these changes do?
Adds
add-note
command to Tune CLI. Builds on top of #3983