Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] add-note command for Tune CLI #4321

Merged
merged 6 commits into from
Mar 11, 2019

Conversation

andrewztan
Copy link
Contributor

What do these changes do?

Adds add-note command to Tune CLI. Builds on top of #3983

@andrewztan andrewztan changed the title [tune] add-note command to Tune CLI [tune] add-note command for Tune CLI Mar 10, 2019
@andrewztan
Copy link
Contributor Author

@richardliaw

@andrewztan
Copy link
Contributor Author

andrewztan commented Mar 10, 2019

Questions:

  1. Should we limit to just txt files?
  2. Should the --filename flag be the full filename (e.g. note.txt) or just name (e.g. note), or allow for both?
  3. In addition to experiment folders, should add-note be allowed in project or other folders?
  4. What feedback do we want to give the user during and after the note editing experience?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12731/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12733/
Test FAILed.

@richardliaw
Copy link
Contributor

richardliaw commented Mar 10, 2019

Questions:

  1. Should we limit to just txt files?

Well, the default should just be note.txt for now. I don't think you need to worry about otherwise.

  1. Should the --filename flag be the full filename (e.g. note.txt) or just name (e.g. note), or allow for both?

Full name should be good.

  1. In addition to experiment folders, should add-note be allowed in project or other folders?

Yeah, that should be fine.

  1. What feedback do we want to give the user during and after the note editing experience?

What do you have in mind for this?

@hartikainen
Copy link
Contributor

This is nice! I think it would also be great to be able to add notes when launching an experiment.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine for now; I'll try this out tomorrow.

I think later on this should maybe somehow use a starter template?

@richardliaw
Copy link
Contributor

This is nice! I think it would also be great to be able to add notes when launching an experiment.

Hm, via run_experiments as a config like note=str?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12747/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12750/
Test PASSed.

@hartikainen
Copy link
Contributor

@richardliaw Yeah, something like note=str would be nice, although I'm not sure if adding things like that might make the api cluttered at some point.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/12756/
Test PASSed.

@richardliaw
Copy link
Contributor

@hartikainen I'll merge this for now (just as a preliminary first cut to get something in), but in a later PR we'll expose the contents of this note file through tune ls and then we can add a Python API for modifying after iterating.

@richardliaw richardliaw merged commit c435013 into ray-project:master Mar 11, 2019
@richardliaw
Copy link
Contributor

@andrewztan nice work!

@andrewztan andrewztan deleted the add_note branch March 12, 2019 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants