[ray dashboard] Serve deployment page not loading UI bug fix #43279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 19, 2024 23:04
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
Signed-off-by: Nikita Vemuri <[email protected]>
nikitavemuri
force-pushed
the
nikita/deployment_page_ui_bugfix
branch
from
2b1b598
to
ba9953c
Compare
nikitavemuri
changed the title
alanwguo
approved these changes
Feb 20, 2024
khluu
pushed a commit
that referenced
this pull request
Feb 21, 2024
Fixes bug where the serve deployment detail page fails to load if the deployment is in "Starting" state Manual Testing: Create and run serve deployment with infeasible resources so the deployment remains in the "Starting" state Before this PR clicking an individual deployment from the "Serve" tab would not load. Fixed with this PR. --------- Signed-off-by: Nikita Vemuri <[email protected]> Co-authored-by: Nikita Vemuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Manual Testing:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.