Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Fix read_parquet_benchmark_single_node by update parallelism -> override_num_blocks #43752

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

scottjlee
Copy link
Contributor

@scottjlee scottjlee commented Mar 6, 2024

Why are these changes needed?

Continuation of #43692, update release test code with remaining needed changes for replacing parallelism parameter with override_num_blocks.

Related issue number

Closes #43745

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy

@scottjlee scottjlee marked this pull request as ready for review March 6, 2024 20:01
use_threads=use_threads,
filter=filter,
columns=columns,
).materialize()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove the materialize, since the benchmark function run_materialize_ds runs the timer when materializing.

Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@c21 c21 merged commit 36241dd into ray-project:master Mar 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release test read_parquet_benchmark_single_node.aws failed
2 participants