[RLlib] 2 fixes for 2.10 release: 1) DDP + GPU fix; 2) py3.8 fix for uniting two dicts #44000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla,
kouroshHakha and
simonsays1980
as code owners
sven1977
commented
Mar 14, 2024
| @@ -871,7 +871,7 @@ def step(self) -> ResultDict: | |||
| results = self._compile_iteration_results( | |||
| episodes_this_iter=episodes_this_iter, | |||
| step_ctx=train_iter_ctx, | |||
| iteration_results=train_results | eval_results, | |||
| iteration_results={**train_results, **eval_results}, | |||
There was a problem hiding this comment.
py3.8 does not support dict | dict.
There was a problem hiding this comment.
Isn't py3.8 deprecated by the next Ray release version?
sven1977
commented
Mar 14, 2024
| @@ -183,6 +183,13 @@ def _save_module_metadata(self, *args, **kwargs): | |||
| def _module_metadata(self, *args, **kwargs): | |||
| return self.unwrapped()._module_metadata(*args, **kwargs) | |||
|
|
|||
| # TODO (sven): Figure out a better way to avoid having to method-spam this wrapper | |||
There was a problem hiding this comment.
We need to find a better solution for this, but this fixes PPO + multi-GPU on the new stack for now.
simonsays1980
approved these changes
Mar 14, 2024
| @@ -871,7 +871,7 @@ def step(self) -> ResultDict: | |||
| results = self._compile_iteration_results( | |||
| episodes_this_iter=episodes_this_iter, | |||
| step_ctx=train_iter_ctx, | |||
| iteration_results=train_results | eval_results, | |||
| iteration_results={**train_results, **eval_results}, | |||
There was a problem hiding this comment.
Isn't py3.8 deprecated by the next Ray release version?
| # class, whenever we add a new API to any wrapped RLModule here. We could try | ||
| # auto generating the wrapper methods, but this will bring its own challenge | ||
| # (e.g. recursive calls due to __getattr__ checks, etc..). | ||
| def _compute_values(self, *args, **kwargs): |
There was a problem hiding this comment.
Btw: Can't we also compile this method?
8 tasks
khluu
pushed a commit
that referenced
this pull request
Mar 14, 2024
Cherry pick #44000 Signed-off-by: sven1977 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 fixes for 2.10 release: 1) DDP + GPU fix; 2) py3.8 fix for uniting two dicts
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.