Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix MultiCallbacks on_sample_end signature. #44040

Conversation

sven1977
Copy link
Contributor

Fix MultiCallbacks on_sample_end signature.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
@@ -945,10 +945,18 @@ def on_postprocess_trajectory(

@override(DefaultCallbacks)
def on_sample_end(
self, *, worker: "EnvRunner", samples: SampleBatch, **kwargs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the bug: MultiAgentEnvRunner and SingleAgentEnvRunner call this without the worker arg (but then env_runner is provided), leading to a

TypeError: make_multi_callbacks.<locals>._MultiCallbacks.on_sample_end() missing 1 required keyword-only argument: 'worker'

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Mar 15, 2024
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! LGTM.

@sven1977 sven1977 merged commit 7cd8067 into ray-project:master Mar 15, 2024
9 checks passed
@sven1977 sven1977 deleted the fix_multi_callbacks_on_sample_end_signature branch March 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants