Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pick][data] turn off actor locality by default #44124

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[Pick][data] turn off actor locality by default #44124

merged 1 commit into from
Mar 19, 2024

Conversation

raulchen
Copy link
Contributor

Why are these changes needed?

Cherry-pick #44123

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

c21
c21 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical fix for Ray Data GA.

zhe-thoughts
zhe-thoughts approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khluu FYI. Unfortunately we do need to pick this

@khluu khluu merged commit 09abba2 into ray-project:releases/2.10.0 Mar 19, 2024
5 checks passed
@raulchen raulchen deleted the cp-turn-off-actor-locality branch March 19, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@scottjlee scottjlee scottjlee approved these changes

@c21 c21 c21 approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees

@c21 c21

@zhe-thoughts zhe-thoughts

@khluu khluu

Labels
v2.10.0-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raulchen @c21 @scottjlee @zhe-thoughts @khluu