[core] Only raise RayTaskError if user exception cannot be subclassed. #44379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the caller of `ray.get(obj_ref)` where caller can catch it. For ease of use, Ray makes a *dual* exception that inherits both `RayTaskError` and the user exception type, so it can be caught as either. Problem is, if the user exception is marked `@final`, we can't make such a dual exception. Notably, Pydantic v2 ValidationError is `@final`. This PR handles such case by issuing a warning and only raise the `RayTaskError`. The user exception can be accessed as `ray_task_error.cause`. Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
jjyao
reviewed
Apr 5, 2024
jjyao
reviewed
Apr 5, 2024
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
angelinalg
reviewed
Apr 8, 2024
angelinalg
approved these changes
Apr 8, 2024
jjyao
reviewed
Apr 10, 2024
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
jjyao
approved these changes
Apr 11, 2024
|
Test failed and is related. |
Co-authored-by: Jiajun Yao <[email protected]> Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Signed-off-by: Ruiyang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Ray Task raises user exceptions, the exception is forwarded to the caller of
ray.get(obj_ref)where caller can catch it. For ease of use, Ray makes a dual exception that inherits bothRayTaskErrorand the user exception type, so it can be caught as either.Problem is, if the user exception is marked
@final, we can't make such a dual exception. Notably, Pydantic v2 ValidationError is@final. This PR handles such case by issuing a warning and only raise theRayTaskError. The user exception can be accessed asray_task_error.cause.Fixes #43401.