Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix IMPALA/APPO old API stack queueing stats. #44446

Merged
merged 2 commits into from
Apr 4, 2024
Merged

[RLlib] Fix IMPALA/APPO old API stack queueing stats. #44446

merged 2 commits into from
Apr 4, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Apr 3, 2024 •
edited
Loading

Fix IMPALA/APPO old API stack queueing stats.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
6aa57a0 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 changed the title [RLlib] Fix broken RLlib examples folder links (introduced by prior examples scripts PR). [RLlib] Fix IMPALA/APPO old API stack queueing stats. Apr 3, 2024
simonsays1980
simonsays1980 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977
wip
0de7242 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 added rllib RLlib related issues rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack labels Apr 3, 2024
@sven1977 sven1977 merged commit 81ae980 into ray-project:master Apr 4, 2024
5 checks passed
@sven1977 sven1977 deleted the fix_impala_appo_memory_leak branch October 10, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

Assignees

@simonsays1980 simonsays1980

Labels
rllib RLlib related issues rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sven1977 @simonsays1980 @angelinalg