Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Address possible memory inefficiency in WorkerSet.sync_weights (b/c not using ray.put()). #44491

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Apr 5, 2024

  • Address possible memory inefficiency in WorkerSet.sync_weights (b/c not using ray.put()). NOTE that this is already implemented correctly for the new API stack (see Algorithm.sync_env_runner_states()), but we missed retro-fixing this for the old API stack.
  • Address instances of RLlib referencing larger objects (via self) from within a remote function, causing this large object to be pickle-copied num_worker times (instead of just passing the necessary property value from that self).
  • Minor Algorithm method deprecation and cleanup.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Great catches by the customer. I am curious, if this will give some significant performance gains in the base algorithms.

Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 merged commit 285a3f4 into ray-project:master Apr 5, 2024
5 checks passed
@sven1977 sven1977 deleted the fix_memory_leak_in_worker_set_sync_weights branch April 5, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants